New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Initialize UIs in user preferred language on the first run #28254

Merged

Mugen87 merged 1 commit into mrdoob:dev from ycw:autodetect-ui-lang

May 2, 2024

Contributor

ycw commented May 1, 2024 •

edited

Loading

This PR inits UIs in user-preferred lang on the first run (i.e. when localStorage is empty); fallback to en if lang isn't fr | ja | zh.

To test:

Go to browser settings, set preferred language to Japanese, then
Open https://raw.githack.com/ycw/three.js/autodetect-ui-lang/editor/index.html in incognito mode (mimic first run), then
UIs should be shown in Japanese


          init ui in user preferred lang on 1st run

959e486

Mugen87 approved these changes

View reviewed changes

Mugen87 added this to the r165 milestone

Mugen87 merged commit 01bc290 into mrdoob:dev

7 of 11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet