Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: update viewport node on RENDER #28370

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

aardgoose
Copy link
Contributor

Related issue: #28343

As noted by @WestLangley the line width in the inset viewport of the webgpu fat line example https://threejs.org/examples/?q=fat#webgpu_lines_fat is not scaled correctly. Updating the viewport on per render instead of per frame fixes this.

@Mugen87
Copy link
Collaborator

Mugen87 commented May 13, 2024

For some reasons, webgpu_instance_points still fails. Since regenerating the screenshot does not help, put the example in the exception list for now.

const exceptionList = [

@sunag sunag added this to the r165 milestone May 14, 2024
@Mugen87 Mugen87 merged commit d7d82ed into mrdoob:dev May 14, 2024
11 checks passed
@aardgoose aardgoose deleted the viewport branch May 23, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants