Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Makes all shadings modes honor the viewport camera #28426

Merged
merged 1 commit into from
May 20, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 19, 2024

This PR makes all shading modes honor the viewport camera

Preview: https://raw.githack.com/ycw/three.js/editor-shading-honors-viewport-camera/editor/index.html (aspect ratio issue is fixed in another PR #28425)

With this PR:

shading-honors-viewport-camera.mp4

@mrdoob mrdoob added this to the r165 milestone May 20, 2024
@mrdoob mrdoob merged commit 6651acf into mrdoob:dev May 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants