Editor: Fixed wrong script title when editing shader #28444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue: When users edit shader in script editor, and then rename the material they're editing
then, the script title becomes ...
{objectname} / undefined,which should be ...
{materialname} / XXX Shader.The bug demo:
script.title.bugs.mp4
With this PR:
set.proper.script.title.mp4
Details:
Renaming material will dispatch materialChanged followed by objectChanged, so we've to guard objectChanged from setting title (this is the cause of the bug)
Added setTitle to set title in single place (yet l10n)
Added missing
defaultinswitches, this is not related to the bug, but I found it helpful during debugging.