Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLRenderer: Clean up transmission clear statements #28449

Closed
wants to merge 2 commits into from
Closed

WebGLRenderer: Clean up transmission clear statements #28449

wants to merge 2 commits into from

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #28434 (comment)

Description

Ensure clear is not called twice.

@gkjohnson gkjohnson added this to the r165 milestone May 21, 2024
@gkjohnson gkjohnson requested a review from Mugen87 May 21, 2024 12:14
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
679.1 kB (168.3 kB) 679.1 kB (168.3 kB) -1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.1 kB (110.3 kB) 457.1 kB (110.4 kB) -1 B

@Mugen87
Copy link
Collaborator

Mugen87 commented May 21, 2024

Already filed a PR here^^: #28447

@Mugen87 Mugen87 closed this May 21, 2024
@Mugen87 Mugen87 removed this from the r165 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Awaiting requested review from Mugen87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkjohnson @Mugen87