Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderPass: Make the render background get the correct Alpha #28459

Merged
merged 1 commit into from
May 22, 2024
Merged

RenderPass: Make the render background get the correct Alpha #28459

merged 1 commit into from
May 22, 2024

Conversation

zhaocaho
Copy link
Contributor

@zhaocaho zhaocaho commented May 22, 2024 •
edited
Loading

Description

There's a bug in RenderPass.Before getting the oldClearAlpha = renderer.getClearAlpha(), the method renderer.setClearColor was called to make the oldClearAlpha=1.

@Mugen87 Mugen87 added this to the r165 milestone May 22, 2024
@Mugen87 Mugen87 merged commit 687a4ca into mrdoob:dev May 22, 2024
11 checks passed
@Mugen87
Copy link
Collaborator

Mugen87 commented May 22, 2024

@zhaocaho Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r165
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaocaho @Mugen87