Editor: Fixed bouncy view in sidebar caused by scrollIntoView()
#28485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
May 24, 2024
ycw
force-pushed
the
editor-uitabbedpanel-no-scrollintoview
branch
from
5f20b71 to
d9a0598
Compare
Mugen87
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue: Currently when users selected an object in a long outliner(or simply add objects), the sidebar will be scrolled way up to show active property tab (e.g. SCRIPT) into view, this causes a bouncy view. The expected behavior should be scrolling the active property tabs inside the tabsDiv container only:
bouncy.issue.when.using.scrollIntoView.mp4
This PR fixed that issue, by using
scrollTo(), instead ofscrollIntoView().no.bouncy.issue.when.using.scrollTo.mp4
Preview: https://raw.githack.com/ycw/three.js/editor-uitabbedpanel-no-scrollintoview/editor/index.html
Details:
scrollIntoViewbehavior:bidir.auto.scrollto.mp4