Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Avoid primitive restart values in index array #28641

Merged
merged 2 commits into from
Jun 14, 2024
Merged

BatchedMesh: Avoid primitive restart values in index array #28641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c94863
BatchedMesh: Avoid primitive restart values in index array
donmccurdy Jun 12, 2024
d098de8
BatchedMesh: Add clarifying comment on primitive restart
donmccurdy Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/objects/BatchedMesh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ class BatchedMesh extends Mesh {

if ( reference.getIndex() !== null ) {

const indexArray = maxVertexCount > 65536
// Reserve last u16 index for primitive restart.
const indexArray = maxVertexCount > 65535
? new Uint32Array( maxIndexCount )
: new Uint16Array( maxIndexCount );

Expand Down