-
-
Notifications
You must be signed in to change notification settings - Fork 36k
MaterialX: Add basic support for time
and frame
#29149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The |
Thanks! |
Hi @sunag, do you happen to have a testcase online where this works? I'm still getting errors with the file I had attached to the original issue, presumably because "in" is a reserved word: ![]() Any ideas? EDIT: I added a hack in getUniformFromNode to avoid this: getUniformFromNode( node, type, shaderStage = this.shaderStage, name = null ) {
if ( name === 'in' ) {
console.warn( 'NodeBuilder: "in" is a reserved word, using "inValue" instead.', node, name );
node.name = 'inValue';
name = node.name;
} |
This looks like an old issue, are you using |
This changelist adds a deprecated `fps` input to the specification and implementations of the `time` node, providing continuity of node signatures for applications using earlier versions of the MaterialX data libraries. In a future minor version upgrade, we can then formally remove this input, providing version upgrade logic to handle earlier assets. In a quick survey of `time` node implementations, the `fps` input appears to be unused in practice, making this proposed approach a reasonable match with industry expectations: https://developer.apple.com/documentation/shadergraph/application/time-(float) https://www.sidefx.com/docs/houdini/nodes/vop/mtlxtime.html mrdoob/three.js#29149
This changelist adds a deprecated `fps` input to the specification and implementations of the `time` node, providing continuity of node signatures for applications using earlier versions of the MaterialX data libraries. In a future minor version upgrade, we can then formally remove this input, providing version upgrade logic to handle earlier assets. In a quick survey of `time` node implementations, the `fps` input appears to be ignored, making this proposed approach a reasonable match with industry expectations: https://developer.apple.com/documentation/shadergraph/application/time-(float) https://www.sidefx.com/docs/houdini/nodes/vop/mtlxtime.html mrdoob/three.js#29149
This changelist adds a deprecated `fps` input to the specification and implementations of the `time` node, providing continuity of node signatures for applications using earlier versions of the MaterialX data libraries. In a future minor version upgrade, we can then formally remove this input, providing version upgrade logic to handle earlier assets. In a quick survey of `time` node implementations, the `fps` input appears to be ignored, making this proposed approach a reasonable match with industry expectations: https://developer.apple.com/documentation/shadergraph/application/time-(float) https://www.sidefx.com/docs/houdini/nodes/vop/mtlxtime.html mrdoob/three.js#29149
Related issue: Closes #28985