Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorManagement: Fix rendering to linear spaces #29543

Merged
merged 2 commits into from
Oct 2, 2024
Merged

ColorManagement: Fix rendering to linear spaces #29543

merged 2 commits into from
Oct 2, 2024

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Oct 2, 2024 •
edited
Loading

@donmccurdy donmccurdy mentioned this pull request Oct 2, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 688.08
170.59		 688.13
170.5		 +52 B
-89 B
WebGPU 807.1
217.42		 807.15
217.43		 +52 B
+4 B
WebGPU Nodes 806.61
217.29		 806.66
217.29		 +52 B
+4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.8
111.78		 462.85
111.78		 +52 B
+3 B
WebGPU 535.9
144.69		 535.95
144.69		 +52 B
+3 B
WebGPU Nodes 491.98
134.42		 492.03
134.42		 +52 B
+3 B

@Mugen87 Mugen87 added this to the r170 milestone Oct 2, 2024
@Mugen87 Mugen87 merged commit 1e67d7e into mrdoob:dev Oct 2, 2024
12 checks passed
@donmccurdy donmccurdy deleted the fix/colormanagement-output-linear-srgb branch October 2, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r170
Development

Successfully merging this pull request may close these issues.

WebGLRenderer: setting outputColorSpace to LinearSRGBColorSpace throws error
2 participants
@donmccurdy @Mugen87