WebGPURenderer: Logarithmic Depth Refinement #29561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Removed unnecessary TODO in NodeMaterial.js. 3. Removed unnecessary ".add( 1 ).div( 2 )" from the log depth calculation and added more detail to the log depth comments in ViewportDepthNode.js.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
…thToLogarithmicDepth(), added Desmos link for logarithmic curve visualization.
…shifted to the left as cameraNear increases. Updated Desmos graph link.
sunag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refinement to PR #29447:
Improved wording in a TODO comment in AnalyticLightNode.js.
Removed unnecessary comments in NodeMaterial.js. First, the cameraNear/cameraFar nodes should be used, so the comment stating that they shouldn't be used is inaccurate. Second, the comment describing the
float(1e27)bug now has its own issue report TSL: Using float(1e21) causes a shader syntax error, but uniform(1e21) does not #29560Removed unnecessary ".add( 1 ).div( 2 )" operations from the log depth calculation and added more detail to the log depth comments in ViewportDepthNode.js.