Addons: Add OutlineNode.
#29575
Merged
Addons: Add OutlineNode.
#29575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a curious accuracy problem. The WebGL version appears to have more refined blur. WebGL WebGPU |
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29295
Description
This ports
OutlinePasstoWebGPURendererasOutlineNode.The great thing about this port is that
setRenderObjectFunction()allows a cleaner implementation since no visibility toggling via hierarchy traversal is required anymore. That was by far the most messy part of the previous code and also a performance issue for scenes with many 3D objects.