Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTAONode: Fix AO with WebGL backend. #29588

Merged
merged 2 commits into from
Oct 8, 2024
Merged

GTAONode: Fix AO with WebGL backend. #29588

merged 2 commits into from
Oct 8, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 8, 2024

Related issue: #29587 (comment)

Description

The PR fixes GTAONode for the WebGL backend by creating two helper functions getViewPosition() and getSceneUv() which handle WebGPU/WebGL specific uv convention issues.

This logic is also required for the upcoming SSRNode and potentially third-party and app related code.

@Mugen87 Mugen87 added this to the r170 milestone Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.82
170.9
689.82
170.9
+0 B
+0 B
WebGPU 809.73
218.11
810.12
218.24
+395 B
+128 B
WebGPU Nodes 809.24
217.98
809.63
218.1
+395 B
+126 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 535.76
144.59
535.76
144.59
+0 B
+0 B
WebGPU Nodes 491.87
134.33
491.87
134.33
+0 B
+0 B

@Mugen87 Mugen87 merged commit 55cf949 into mrdoob:dev Oct 8, 2024
12 checks passed
Mugen87 added a commit that referenced this pull request Oct 8, 2024
Mugen87 added a commit that referenced this pull request Oct 8, 2024
@Mugen87 Mugen87 removed this from the r170 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant