Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix missing updates to geometry attributes #29589

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Fixed: #29582
Related: #29386

Description
This PR fixes an issue in NodeMaterialObserver where changes to geometry attributes or properties were not consistently reflected in the material, ensuring proper updates and synchronization between geometry and shaders.

This contribution is funded by Utsubo

Copy link

github-actions bot commented Oct 8, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.82
170.9
689.82
170.9
+0 B
+0 B
WebGPU 811.56
218.6
812.39
218.82
+835 B
+217 B
WebGPU Nodes 811.07
218.47
811.9
218.69
+835 B
+216 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 535.78
144.59
536.62
144.83
+835 B
+239 B
WebGPU Nodes 491.89
134.34
492.73
134.56
+835 B
+223 B

@RenaudRohlinger RenaudRohlinger changed the title WebGPURenderer: Fix geometry attribute not updated regardless of version WebGPURenderer: Fix missing updates to geometry attributes Oct 8, 2024
@sunag sunag added this to the r170 milestone Oct 8, 2024
@sunag sunag merged commit 0e17a92 into mrdoob:dev Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPURenderer: NodeMaterialObserver can prevent BufferAttributes from being updated despite needsUpdate
2 participants