Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: remove obsolete code #29596

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

aardgoose
Copy link
Contributor

RenderList.getLightsNode() has no callers and calls a LightsNode method that has been removed.
Remove obsolete method.

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.82
170.9
689.82
170.9
+0 B
+0 B
WebGPU 811.56
218.6
811.49
218.59
-68 B
-14 B
WebGPU Nodes 811.07
218.47
811
218.46
-68 B
-14 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 535.78
144.59
535.71
144.58
-68 B
-17 B
WebGPU Nodes 491.89
134.34
491.83
134.32
-68 B
-18 B

@RenaudRohlinger RenaudRohlinger added this to the r170 milestone Oct 9, 2024
@RenaudRohlinger RenaudRohlinger merged commit aa9e4ce into mrdoob:dev Oct 9, 2024
12 checks passed
@aardgoose aardgoose deleted the render-list branch October 10, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants