Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflectorNode: Remove getTextureNode(). #29609

Merged
merged 1 commit into from
Oct 10, 2024
Merged

ReflectorNode: Remove getTextureNode(). #29609

merged 1 commit into from
Oct 10, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 10, 2024

Related issue: -

Description

This PR removes the method getTextureNode() from ReflectorNode since the class has no property textureNode.

ReflectorNode is extended from TextureNode so instances of ReflectorNode can directly be used without calling getTextureNode().

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.82
170.9
689.82
170.9
+0 B
+0 B
WebGPU 812.49
218.86
812.45
218.85
-41 B
-4 B
WebGPU Nodes 812
218.73
811.96
218.72
-41 B
-4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 536.56
144.82
536.56
144.82
+0 B
+0 B
WebGPU Nodes 492.68
134.55
492.68
134.55
+0 B
+0 B

@Mugen87 Mugen87 added this to the r170 milestone Oct 10, 2024
@sunag sunag merged commit 06e4cf1 into mrdoob:dev Oct 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants