Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AfterimagePass: Use copy shader. #29691

Merged
merged 1 commit into from
Oct 18, 2024
Merged

AfterimagePass: Use copy shader. #29691

merged 1 commit into from
Oct 18, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 18, 2024

Fixed #29521.

Description

Like other FX passes, AfterimagePass should use CopyShader for internal copies and not MeshBasicMaterial. Transparent backgrounds are supported if the app defines a clear alpha value of 0 (e.g. via renderer.setClearColor( 0x000000, 0 );).

@Mugen87 Mugen87 added this to the r170 milestone Oct 18, 2024
@Mugen87 Mugen87 merged commit afd5105 into mrdoob:dev Oct 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider add {transparent: true} for new MeshBasicMaterial() in AfterimagePass.js
1 participant