-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebXRManager: Inherit active layers from camera #29742
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
/cc @cabanier |
Just in case it's useful, see #26340 |
This PR causes layer=1 and layer=2 to be both activated for the XR camera. See the following two issues: |
The PR just ensures to retain an existing layer configurations of the non-XR scene camera. That was a annoying issue in the past and fixed with this PR.
This was also true before this PR was merged. Do you mind explaining in more detail the regression that you are facing? |
The cause of the issue has been found (see pmndrs/xr#398). For context, the issue lies in renderer.render(scene, renderer.xr.getCamera()); |
Fixed #24354
Description
This PR updates the
WebXRManager
to copy over the layers mask to the XR cameras. The respective eye layer (1 for left, 2 for right) is always enabled in addition.renderer.render(scene, camera)
now always respectscamera.layers
whether XR is active or notThis contribution is funded by Fern Solutions