Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: remove some debugging code #29822

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

aardgoose
Copy link
Contributor

I think this can be safely removed, I have only see it trigger when working on a PR and breaking something.

Copy link

github-actions bot commented Nov 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.21
171.45
692.21
171.45
+0 B
+0 B
WebGPU 821.89
221.91
821.67
221.84
-219 B
-72 B
WebGPU Nodes 821
221.7
820.79
221.63
-219 B
-73 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.56
112.27
464.56
112.27
+0 B
+0 B
WebGPU 542.09
146.75
541.87
146.68
-219 B
-77 B
WebGPU Nodes 498.03
136.5
497.81
136.41
-219 B
-88 B

@RenaudRohlinger
Copy link
Collaborator

I still have this issue when one of my app freezes (on resize event is triggered recreating multiples RTTs in runtime for example) while the bindGroup gets constantly recreated because of a binding issue similar to #29198 (comment).
I can fix it in my code but I believe that a potential solution might lie in improving the caching strategy for RTTs.
Let's just keep this bit while #29198 is still unresolved. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants