Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer: Fix getShaderAsync(). #29832

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Renderer: Fix getShaderAsync(). #29832

merged 1 commit into from
Nov 7, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 7, 2024

Related issue: -

Description

Fixes the currently broken getShaderAsync().

@Mugen87 Mugen87 added this to the r171 milestone Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.22
171.45		 692.22
171.45		 +0 B
+0 B
WebGPU 825.17
222.84		 825.22
222.85		 +46 B
+10 B
WebGPU Nodes 824.29
222.63		 824.33
222.64		 +46 B
+10 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.58
112.26		 464.58
112.26		 +0 B
+0 B
WebGPU 545.38
147.7		 545.43
147.71		 +46 B
+10 B
WebGPU Nodes 501.32
137.43		 501.37
137.44		 +46 B
+10 B

@Mugen87 Mugen87 mentioned this pull request Nov 7, 2024
Closed
@Mugen87 Mugen87 merged commit 3728a0a into mrdoob:dev Nov 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r171
Development

Successfully merging this pull request may close these issues.
1 participant
@Mugen87