WebGPURenderer: Handle OutOfMemory in Timestamp Tracking #29857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add fallback for GPUOutOfMemoryError via
device.pushErrorScope( 'out-of-memory' )
when creating timestamp query set. This prevents renderer breakage caused by failed sample buffer allocation.Also added an error message suggesting users close other GPU-intensive tabs to enable timestamp measurements as it's in most case the issue triggering the error.
Before (crashing the renderer):
After (handle error, nothing breaks):
This contribution is funded by Utsubo