New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLBackground: Add `dispose()`. #29858

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev3

Nov 11, 2024

Collaborator

Mugen87 commented Nov 11, 2024

Related issue: #26897 (comment)

Description

The PR makes sure the internal plane and box mesh of WebGLBackground are honored during a dispose() call of the renderer.


          WebGLBackground: Add dispose().

3452a84

Mugen87 added this to the r171 milestone

github-actions bot commented Nov 11, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	339.22 79.04	339.37 79.06	+145 B +25 B
WebGPU	477.43 132.37	477.43 132.37	+0 B +0 B
WebGPU Nodes	476.73 132.2	476.73 132.2	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	464.67 111.99	464.82 112.02	+145 B +26 B
WebGPU	546.47 148.04	546.47 148.04	+0 B +0 B
WebGPU Nodes	502.35 137.74	502.35 137.74	+0 B +0 B

Mugen87 merged commit b276fb5 into mrdoob:dev

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet