Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderObjects: Force material.needsUpdate=true to update the material if geometry is changed. #29873

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 13, 2024

Related issue: #29836

Description

Force material.needsUpdate=true to update the material if geometry is changed.

@sunag sunag added this to the r171 milestone Nov 13, 2024
@sunag sunag marked this pull request as ready for review November 13, 2024 17:34
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.37
79.06
339.37
79.06
+0 B
+0 B
WebGPU 477.96
132.56
477.94
132.55
-19 B
-10 B
WebGPU Nodes 477.43
132.44
477.41
132.42
-19 B
-12 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.82
112.02
464.82
112.02
+0 B
+0 B
WebGPU 546.89
148.19
546.87
148.17
-19 B
-14 B
WebGPU Nodes 502.77
137.89
502.75
137.88
-19 B
-15 B

@sunag sunag changed the title RenderObjects: Force material.needsUpdate=true to update the material RenderObjects: Force material.needsUpdate=true to update the material if geometry is changed. Nov 13, 2024
@sunag sunag merged commit e5e8d20 into mrdoob:dev Nov 13, 2024
12 checks passed
@sunag sunag deleted the dev-fix-customaterial branch November 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant