Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer: Add hasInitialized(). #29937

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Renderer: Add hasInitialized(). #29937

merged 1 commit into from
Nov 20, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 20, 2024

Related issue: #29922 (comment)

Description

The PR adds hasInitialized() to Renderer so developers can check if the renderer is ready for usage.

@sunag sunag added this to the r171 milestone Nov 20, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.13
79
339.13
79
+0 B
+0 B
WebGPU 478.72
132.72
478.76
132.73
+42 B
+8 B
WebGPU Nodes 478.18
132.6
478.23
132.61
+42 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.59
111.96
464.59
111.96
+0 B
+0 B
WebGPU 546.88
148.18
546.92
148.18
+42 B
+8 B
WebGPU Nodes 502.76
137.89
502.8
137.9
+42 B
+10 B

@sunag sunag merged commit e30ebff into mrdoob:dev Nov 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants