Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: fix typos #30013

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Node: fix typos #30013

merged 1 commit into from
Dec 2, 2024

Conversation

s-rigaud
Copy link
Contributor

@s-rigaud s-rigaud commented Dec 2, 2024

Description

Fix some minor typos in the Node folder

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98		 339.11
78.98		 +0 B
+0 B
WebGPU 484.57
134.48		 484.57
134.48		 +1 B
-3 B
WebGPU Nodes 484.04
134.38		 484.04
134.38		 +1 B
-1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.62
111.98		 464.62
111.98		 +0 B
+0 B
WebGPU 553.36
149.77		 553.36
149.77		 +0 B
+0 B
WebGPU Nodes 509.24
139.48		 509.24
139.48		 +0 B
+0 B

@Mugen87 Mugen87 merged commit 036e03e into mrdoob:dev Dec 2, 2024
12 checks passed
@Mugen87 Mugen87 added this to the r172 milestone Dec 2, 2024
@s-rigaud s-rigaud deleted the docs-fix-typos branch December 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87