Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Fix positionWorld used in material.positionNode and fragment-stage #30105

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 11, 2024

Description

positionWorld was performant once if used on positionNode and colorNode at the same time. However positionNode should make changes to positionWorld if used in fragment-stage, this PR re-assigns positionWorld if used in both.

@sunag sunag added this to the r172 milestone Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01
339.21
79.01
+0 B
+0 B
WebGPU 485.91
134.87
486.25
134.97
+340 B
+98 B
WebGPU Nodes 485.38
134.77
485.72
134.86
+340 B
+93 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06
465.1
112.06
+0 B
+0 B
WebGPU 555.02
150.3
555.36
150.39
+340 B
+84 B
WebGPU Nodes 510.87
140.01
511.21
140.1
+340 B
+86 B

@sunag sunag marked this pull request as ready for review December 11, 2024 16:14
@sunag sunag merged commit a93ab32 into mrdoob:dev Dec 11, 2024
12 checks passed
@sunag sunag deleted the dev-position-reassign branch December 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant