Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Improve some types #30110

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Node: Improve some types #30110

merged 1 commit into from
Dec 12, 2024

Conversation

s-rigaud
Copy link
Contributor

Description

Improve some JSdoc types in the src/nodes folder.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01		 339.21
79.01		 +0 B
+0 B
WebGPU 486.3
134.97		 486.3
134.97		 +0 B
+0 B
WebGPU Nodes 485.76
134.87		 485.76
134.87		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06		 465.1
112.06		 +0 B
+0 B
WebGPU 555.41
150.39		 555.41
150.39		 +0 B
+0 B
WebGPU Nodes 511.26
140.1		 511.26
140.1		 +0 B
+0 B

@Mugen87 Mugen87 added this to the r172 milestone Dec 12, 2024
@Mugen87 Mugen87 merged commit 234945c into mrdoob:dev Dec 12, 2024
12 checks passed
@s-rigaud s-rigaud deleted the fix-node-types branch December 31, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87