Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaders: typos #30144

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Loaders: typos #30144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions examples/jsm/loaders/PLYLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,19 +127,19 @@ class PLYLoader extends Loader {
const lines = headerText.split( /\r\n|\r|\n/ );
let currentElement;

function make_ply_element_property( propertValues, propertyNameMapping ) {
function make_ply_element_property( propertyValues, propertyNameMapping ) {

const property = { type: propertValues[ 0 ] };
const property = { type: propertyValues[ 0 ] };

if ( property.type === 'list' ) {

property.name = propertValues[ 3 ];
property.countType = propertValues[ 1 ];
property.itemType = propertValues[ 2 ];
property.name = propertyValues[ 3 ];
property.countType = propertyValues[ 1 ];
property.itemType = propertyValues[ 2 ];

} else {

property.name = propertValues[ 1 ];
property.name = propertyValues[ 1 ];

}

Expand Down Expand Up @@ -576,7 +576,7 @@ class PLYLoader extends Loader {

switch ( type ) {

// corespondences for non-specific length types here match rply:
// correspondences for non-specific length types here match rply:
case 'int8': case 'char': return { read: ( at ) => {

return dataview.getInt8( at );
Expand Down
14 changes: 7 additions & 7 deletions examples/jsm/loaders/VRMLLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ class VRMLLoader extends Loader {

function createVisitor( BaseVRMLVisitor ) {

// the visitor is created dynmaically based on the given base class
// the visitor is created dynamically based on the given base class

class VRMLToASTVisitor extends BaseVRMLVisitor {

Expand Down Expand Up @@ -1890,7 +1890,7 @@ class VRMLLoader extends Loader {

// if the colorIndex field is not empty, then one color is used for each polyline of the IndexedLineSet.

const expandedColorIndex = expandLineIndex( colorIndex ); // compute colors for each line segment (rendering primitve)
const expandedColorIndex = expandLineIndex( colorIndex ); // compute colors for each line segment (rendering primitive)
colorAttribute = computeAttributeFromIndexedData( expandedLineIndex, expandedColorIndex, color, 3 ); // compute data on vertex level

} else {
Expand All @@ -1907,16 +1907,16 @@ class VRMLLoader extends Loader {

// if the colorIndex field is not empty, then colors are applied to each vertex of the IndexedLineSet

const flattenLineColors = flattenData( color, colorIndex ); // compute colors for each VRML primitve
const expandedLineColors = expandLineData( flattenLineColors, coordIndex ); // compute colors for each line segment (rendering primitve)
const flattenLineColors = flattenData( color, colorIndex ); // compute colors for each VRML primitive
const expandedLineColors = expandLineData( flattenLineColors, coordIndex ); // compute colors for each line segment (rendering primitive)
colorAttribute = computeAttributeFromLineData( expandedLineIndex, expandedLineColors ); // compute data on vertex level


} else {

// if the colorIndex field is empty, then the coordIndex field is used to choose colors from the Color node

const expandedLineColors = expandLineData( color, coordIndex ); // compute colors for each line segment (rendering primitve)
const expandedLineColors = expandLineData( color, coordIndex ); // compute colors for each line segment (rendering primitive)
colorAttribute = computeAttributeFromLineData( expandedLineIndex, expandedLineColors ); // compute data on vertex level

}
Expand Down Expand Up @@ -2748,7 +2748,7 @@ class VRMLLoader extends Loader {

const indices = [];

// since face defintions can have more than three vertices, it's necessary to
// since face definitions can have more than three vertices, it's necessary to
// perform a simple triangulation

let start = 0;
Expand Down Expand Up @@ -3123,7 +3123,7 @@ class VRMLLoader extends Loader {
* node, but could be applied to other nodes with multiple faces as well.
*
* When used with the Background node, default is directionIsDown is true if
* interpolating the skyColor down from the Zenith. When interpolationg up from
* interpolating the skyColor down from the Zenith. When interpolating up from
* the Nadir i.e. interpolating the groundColor, the directionIsDown is false.
*
* The first angle is never specified, it is the Zenith (0 rad). Angles are specified
Expand Down
Loading