Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: add addMethodsChaining #30201

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Conversation

linbingquan
Copy link
Contributor

Related issue: #XXXX

Description

Simple verification. Should reduce the packing volume.

Copy link

github-actions bot commented Dec 25, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06
339.44
79.06
+0 B
+0 B
WebGPU 488.67
135.59
488.13
135.63
-535 B
+36 B
WebGPU Nodes 488.13
135.48
487.6
135.5
-535 B
+28 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 558.58
151.21
557.92
151.16
-657 B
-52 B
WebGPU Nodes 514.65
140.99
514
140.89
-657 B
-94 B

src/nodes/tsl/TSLCore.js Outdated Show resolved Hide resolved
This reverts commit a91ea44.
@sunag sunag added this to the r172 milestone Dec 25, 2024
@sunag sunag merged commit a7500fd into mrdoob:dev Dec 26, 2024
12 checks passed
@linbingquan linbingquan deleted the dev-addMethodsChaining branch December 26, 2024 03:00
sunag added a commit to sunag/three.js that referenced this pull request Dec 27, 2024
sunag added a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants