Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReflectorNode: No cache event if bounces=false #30231

Merged
merged 1 commit into from
Dec 30, 2024
Merged

ReflectorNode: No cache event if bounces=false #30231

merged 1 commit into from
Dec 30, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 30, 2024

Description

No cache event if bounces=false.

@sunag sunag changed the title ReflectorNode: No cache event if bounces=false ReflectorNode: No cache event if bounces=false Dec 30, 2024
@sunag sunag added this to the r172 milestone Dec 30, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06		 339.44
79.06		 +0 B
+0 B
WebGPU 489.15
135.74		 489.15
135.74		 +2 B
+1 B
WebGPU Nodes 488.61
135.62		 488.62
135.62		 +2 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11		 465.3
112.11		 +0 B
+0 B
WebGPU 558.64
151.24		 558.64
151.24		 +0 B
+0 B
WebGPU Nodes 514.72
141.02		 514.72
141.02		 +0 B
+0 B

@sunag sunag marked this pull request as ready for review December 30, 2024 04:41
@sunag sunag merged commit b1fd13b into mrdoob:dev Dec 30, 2024
12 checks passed
@sunag sunag deleted the dev-reflector-fix branch December 30, 2024 04:42
@sunag sunag mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag