Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTextureUtils: Fix typo. #30238

Merged
merged 1 commit into from
Dec 30, 2024
Merged

WebGLTextureUtils: Fix typo. #30238

merged 1 commit into from
Dec 30, 2024

Conversation

boytchev
Copy link
Contributor

@boytchev boytchev commented Dec 30, 2024

Fixed #30236

Description

The file src/renderers/webgl-fallback/utils/WebGLTextureUtils.js has a call to gerDrawingBufferSize. The name has a typo. This PR fixes this typo with ger...->get.... No other changes are made.

Fixed a typo in a function name.
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06
339.44
79.06
+0 B
+0 B
WebGPU 489.65
135.77
489.65
135.77
+0 B
-3 B
WebGPU Nodes 489.11
135.66
489.11
135.65
+0 B
-2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 559.14
151.28
559.14
151.28
+0 B
-3 B
WebGPU Nodes 515.21
141.07
515.21
141.07
+0 B
-2 B

@Mugen87 Mugen87 added this to the r172 milestone Dec 30, 2024
@Mugen87 Mugen87 merged commit e8af245 into mrdoob:dev Dec 30, 2024
12 checks passed
@Mugen87 Mugen87 changed the title Fixes a typo in WebGLTextureUtils.js (#30236) WebGLTextureUtils: Fix typo. Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGL2 fallback: A possible typo in a function name gerDrawingBufferSize
2 participants