Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPUAttributeUtils: Fix i16a/u16a patch #30264

Merged
merged 2 commits into from
Jan 7, 2025
Merged

WebGPUAttributeUtils: Fix i16a/u16a patch #30264

merged 2 commits into from
Jan 7, 2025

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Jan 4, 2025 •
edited
Loading

i16a should be patched as i32a, not u32a

u16a should be patched as u32a, and honor primitive restart if needed

demo the issue: https://jsfiddle.net/wum6odvn/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.49
79.09		 339.49
79.09		 +0 B
+0 B
WebGPU 489.81
135.9		 489.87
135.93		 +57 B
+33 B
WebGPU Nodes 489.28
135.78		 489.34
135.81		 +57 B
+29 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.35
112.14		 465.35
112.14		 +0 B
+0 B
WebGPU 559.29
151.38		 559.35
151.41		 +57 B
+33 B
WebGPU Nodes 515.37
141.16		 515.42
141.19		 +57 B
+31 B

@sunag sunag added this to the r173 milestone Jan 4, 2025
@sunag sunag merged commit 3212be4 into mrdoob:dev Jan 7, 2025
12 checks passed
@ycw ycw deleted the fix-create-attrib branch January 8, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r173
Development

Successfully merging this pull request may close these issues.
3 participants
@ycw @Mugen87 @sunag