Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpriteNodeMaterial: Fix scaleNode type convertion #30545

Merged
merged 1 commit into from
Feb 17, 2025
Merged

SpriteNodeMaterial: Fix scaleNode type convertion #30545

merged 1 commit into from
Feb 17, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 17, 2025

Fixes: #30539

Description

Fix scaleNode type convertion of SpriteNodeMaterial.

@sunag sunag added this to the r174 milestone Feb 17, 2025
@sunag sunag marked this pull request as ready for review February 17, 2025 15:18
@sunag sunag mentioned this pull request Feb 17, 2025
Closed
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.36
78.33		 336.36
78.33		 +0 B
+0 B
WebGPU 518.85
144		 518.85
144		 +0 B
+1 B
WebGPU Nodes 518.32
143.88		 518.32
143.88		 +0 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.35
112.17		 465.35
112.17		 +0 B
+0 B
WebGPU 590.68
159.95		 590.68
159.95		 +0 B
+2 B
WebGPU Nodes 545.99
149.43		 545.99
149.43		 +0 B
+0 B

@sunag sunag merged commit 82c9bb0 into mrdoob:dev Feb 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r174
Development

Successfully merging this pull request may close these issues.

SpriteNodeMaterial scaleNode accept vec2
2 participants
@sunag @Mugen87