Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsodc: Improve Object3D #30546

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Jsodc: Improve Object3D #30546

merged 2 commits into from
Feb 17, 2025

Conversation

s-rigaud
Copy link
Contributor

Description

Small improvements to the doc.

Typing of lookAt is a bit hard as there is two ways of calling the method, I think this is a better way to signal that second and third parameters are not required in some cases.

Copy link

github-actions bot commented Feb 17, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.36
78.33
336.36
78.33
+0 B
+0 B
WebGPU 518.85
144
518.85
144
+0 B
+0 B
WebGPU Nodes 518.32
143.88
518.32
143.88
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.35
112.17
465.35
112.17
+0 B
+0 B
WebGPU 590.68
159.95
590.68
159.95
+0 B
+0 B
WebGPU Nodes 545.99
149.43
545.99
149.43
+0 B
+0 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 17, 2025
@Mugen87 Mugen87 merged commit b9068ab into mrdoob:dev Feb 17, 2025
10 of 11 checks passed
@s-rigaud s-rigaud deleted the jsodc-improve-object3d branch February 26, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants