Jsdoc: More fixes #30557
Merged
Jsdoc: More fixes #30557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rigaud
force-pushed
the
jsdoc-more-fixes
branch
from
338b257 to
359064e
Compare
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Feb 18, 2025
| @@ -654,7 +654,18 @@ class PassNode extends TempNode { | |||
|
|
|||
| } | |||
|
|
|||
| /** | |||
| * @static | |||
| * @type {'color'} | |||
There was a problem hiding this comment.
Can you please use string here?
There was a problem hiding this comment.
Not really, the type system does not seem to take static as a const and only use the string type so it displays an error
There was a problem hiding this comment.
Okay, I understand the issue now. It's related to how scope of PassNode is defined. The change is indeed correct.
Mugen87
reviewed
Feb 18, 2025
|
|
||
| /** | ||
| * @static | ||
| * @type {'depth'} |
Mugen87
reviewed
Feb 18, 2025
Mugen87
reviewed
Feb 18, 2025
s-rigaud
force-pushed
the
jsdoc-more-fixes
branch
from
359064e to
f48c777
Compare
Mugen87
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix more types in the doc.