Skip to content

webgl_reverse_depth_buffer: Use post-processing and add note for use of floating point depth #30941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mugen87 merged 1 commit into from
Apr 16, 2025
Merged

webgl_reverse_depth_buffer: Use post-processing and add note for use of floating point depth #30941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 42 additions & 24 deletions examples/webgl_reverse_depth_buffer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,15 @@
text-align: center;
}

#depth-warning {
#info_note {
position: absolute;
top: 40px;
top: 24px;
width: 100%;
padding: 10px;
box-sizing: border-box;
text-align: center;
color: #ff5555;
font-weight: bold;
color: rgba(255, 255, 255, 0.8);
z-index: 2;
display: none;
}
</style>
</head>
Expand All @@ -87,8 +85,8 @@
<a href="https://threejs.org" target="_blank" rel="noopener">three.js</a> - reverse depth buffer<br/>
</div>

<div id="depth-warning">
Warning: Your browser's WebGL provides less than 24-bit depth buffer precision. This example may not display correctly.
<div id="info_note">
Note: For best results, a floating-point depth buffer should be used with post-processing. See <a href="https://developer.nvidia.com/blog/visualizing-depth-precision" target="_blank" rel="noopener">Visualizing Depth Precision</a>.
</div>

<script type="importmap">
Expand All @@ -105,10 +103,20 @@
import * as THREE from 'three';

import Stats from 'three/addons/libs/stats.module.js';
import { EffectComposer } from 'three/addons/postprocessing/EffectComposer.js';
import { RenderPass } from 'three/addons/postprocessing/RenderPass.js';
import { OutputPass } from 'three/addons/postprocessing/OutputPass.js';

let stats, camera, scene, normalRenderer, logarithmicRenderer, reverseRenderer;
let stats, camera, scene;
let normalRenderer, logarithmicRenderer, reverseRenderer;
let normalComposer, logarithmicComposer, reverseComposer;
const meshes = [];

const renderTarget = new THREE.WebGLRenderTarget();
renderTarget.type = THREE.UnsignedByteType;
Copy link
Contributor

@Methuselah96 Methuselah96 Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any pointers to what setting the type property does? I don't see it documented for WebGLRenderTarget and was wondering whether it needs to be added to the TypeScript types.

Copy link
Collaborator

@Mugen87 Mugen87 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be:

renderTarget.texture.type

But since the default is already THREE.UnsignedByteType we probably can just delete this line.

Copy link
Contributor Author

@CodyJasonBennett CodyJasonBennett Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bad habit of mine. I will remove the line #30989.

renderTarget.depthTexture = new THREE.DepthTexture();
renderTarget.depthTexture.type = THREE.FloatType;

init();
animate();

Expand Down Expand Up @@ -206,32 +214,34 @@
normalRenderer.domElement.style.position = 'relative';
normalContainer.appendChild( normalRenderer.domElement );

normalComposer = new EffectComposer( normalRenderer, renderTarget );
normalComposer.addPass( new RenderPass( scene, camera ) );
normalComposer.addPass( new OutputPass() );

const logarithmicContainer = document.getElementById( 'container_logarithmic' );
logarithmicRenderer = new THREE.WebGLRenderer( { logarithmicDepthBuffer: true } );
logarithmicRenderer.setPixelRatio( window.devicePixelRatio );
logarithmicRenderer.setSize( 0.33 * window.innerWidth, window.innerHeight );
logarithmicRenderer.domElement.style.position = 'relative';
logarithmicContainer.appendChild( logarithmicRenderer.domElement );

logarithmicComposer = new EffectComposer( logarithmicRenderer, renderTarget );
logarithmicComposer.addPass( new RenderPass( scene, camera ) );
logarithmicComposer.addPass( new OutputPass() );

const reverseContainer = document.getElementById( 'container_reverse' );
reverseRenderer = new THREE.WebGLRenderer( { reverseDepthBuffer: true } );
reverseRenderer.setPixelRatio( window.devicePixelRatio );
reverseRenderer.setSize( 0.33 * window.innerWidth, window.innerHeight );
reverseRenderer.domElement.style.position = 'relative';
reverseContainer.appendChild( reverseRenderer.domElement );

// Check depth buffer precision
const gl = normalRenderer.getContext();

const depthBits = gl.getParameter( gl.DEPTH_BITS );

if ( depthBits < 24 ) {

document.getElementById( 'depth-warning' ).style.display = 'block';

}
reverseComposer = new EffectComposer( reverseRenderer, renderTarget );
reverseComposer.addPass( new RenderPass( scene, camera ) );
reverseComposer.addPass( new OutputPass() );

window.addEventListener( 'resize', onWindowResize );
onWindowResize();

}

Expand All @@ -255,19 +265,27 @@

function render() {

normalRenderer.render( scene, camera );
logarithmicRenderer.render( scene, camera );
reverseRenderer.render( scene, camera );
normalComposer.render();
logarithmicComposer.render();
reverseComposer.render();

stats.update();

}

function onWindowResize() {

normalRenderer.setSize( 0.33 * window.innerWidth, window.innerHeight );
logarithmicRenderer.setSize( 0.33 * window.innerWidth, window.innerHeight );
reverseRenderer.setSize( 0.33 * window.innerWidth, window.innerHeight );
const width = 0.33 * window.innerWidth;
const height = window.innerHeight;
const dpr = window.devicePixelRatio;

normalComposer.setSize( width * dpr, height * dpr );
logarithmicComposer.setSize( width * dpr, height * dpr );
reverseComposer.setSize( width * dpr, height * dpr );

normalRenderer.setSize( width, height );
logarithmicRenderer.setSize( width, height );
reverseRenderer.setSize( width, height );

camera.aspect = 0.33 * window.innerWidth / window.innerHeight;
camera.updateProjectionMatrix();
Expand Down