fix:openthe developer tools are opened, the rotation of TrackballControls becomes very sticky. #30957
Conversation
…ntrols becomes very sticky
| // event listeners | ||
|
|
||
| this._onPointerMove = onPointerMove.bind( this ); | ||
| this._onPointerMove = throttle(onPointerMove.bind( this ),16); |
There was a problem hiding this comment.
Because most devices have a 60Hz refresh rate, the browser has to complete rendering work for each frame within 16ms.
There was a problem hiding this comment.
What about devices with 120Hz, or 240Hz, or 30Hz, ...?
There was a problem hiding this comment.
I’ve thought about this before. I tested it by switching from a 60Hz screen to a 144Hz one (test video is 144Hz), and no lag occurred. But I don’t have devices with refresh rates below 60Hz for testing. I’ll try to find a way to get the screen resolution.
Video:
https://github.com/user-attachments/assets/92047286-ce6d-402e-882c-a51e57208880
|
If the controls are only affected when the developer tools are open, and I don't think it's necessary to apply a patch, tbh. |
|
Agreed. The issue should be reported the DevTools instead... |
3 participants
Description
Problem:
When the developer tools are opened, the rotation of TrackballControls becomes very sticky.
Slove:
When the developer tools are opened, the browser increases the frequency of event triggers.
To solve this problem, a throttle function is added to reduce the number of times the move event is triggered, maintaining the same frequency as when the developer tools are not open.
Video:
https://github.com/user-attachments/assets/92047286-ce6d-402e-882c-a51e57208880