Fix: Avoid false positives in Frustum.intersectsBox #30963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 11, 2025 15:33
Collaborator
|
@mrdoob Do you mind blocking this user? It seems it's a spammer and consistently ignores staff feedback. |
Owner
|
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic in Frustum.intersectsBox to avoid false positives when a box is exactly touching the frustum plane.
Before:
The check used < which could mistakenly return true if a box was perfectly aligned with the outside of the frustum.
After:
Changed to <= for stricter comparison, which prevents this case.
Related issue:
Closes #27756