-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bower.json file #4280
Add bower.json file #4280
Conversation
How about...
|
of course! |
great! :) now, noob question... would this download |
right now it would download both |
What about the examples/js directory ? there is a lot of reusable code in there Should it be in this bower package ? in another ? |
As far as I understand, bower is used to automatically download dependencies, etc? |
@mrdoob Yes indeed, and it's similar to npm: usually front-end dependencies are done with Bower while backend ones get done with npm. The big differences (afaik) are:
|
Thanks! :) |
@jeromeetienne I agree it would be very nice to also download the directory with all these extra three.js classes. It felt somehow weird to download all the JS of the examples folder without the examples... But that folder only has reusable classes, so it makes sense. What do you all think? |
@is-real i think we need a way to install those classes with bower, when we want to use them in our own project. I use bower myself to package my three.js extensions. And some of those extensions uses the this manual copy is what bower is supposed to fix. so yeah i think we should package them. the way to package it is another story, but seems rather simple |
@is-real For the packages, i see 2 possibilities. one simple for the user but may be seen as sloppy. one more rigurous, but more cumbersome for the user my preference seems to go on the first one simple for the user but may be seen as sloppy
It is super simple for the user. but it may install files you dont need. on the other hand nothing prevent you from deleting the files you dont need. one more rigurous but more cumbersome for the user
It ends up with 13 packages by my count... so more cumbersome to the users, but more rigourous because it is less likely to install files you dont need. |
Why not just |
@mrdoob it would be fine by me |
It is also ok for me, but I think we would need then to have a different repo for the examples. |
Basic setup to download the "build" folder when using Bower.