Blender exporter change #4399
Closed
Blender exporter change #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Before this fix the Y position of camera was explicitly negated, causing incorrect camera pos. The reason | ||
| # for negation was unknown, maybe it was needed in some situation. The old line was: | ||
| # "position" : generate_vec3([cameraobj.location[0], -cameraobj.location[1], cameraobj.location[2]], data["flipyz"]), | ||
| "position" : generate_vec3([cameraobj.location[0], cameraobj.location[1], cameraobj.location[2]], data["flipyz"]), |
There was a problem hiding this comment.
The following is equivalent to the proposed change, no?
generate_vec3( cameraobj.location, data[ "flipyz" ] ),
|
@WestLangley You're right. Now it's more certain that there must be a valid reason for this negation (It can't be a typo) Although my app requires this fix, this fix might break some other application. My app uses I wonder if its possible that negation is only required when I suppose its better to hold this PR until it is known why the negation was done in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blender Exporter: Y position of camera was being explicitly negated, causing incorrect camera pos. The reason for negation was unknown, maybe it was needed in some situation.
See Issue: #4207 (comment)