Initial untested spherical harmonics implementation. #6405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding this for future reference: How to calculate SH from a cube texture - http://www.sunandblackcat.com/tipFullView.php?l=eng&topicid=32 |
…e and irradiance to be calculated.
bhouston
force-pushed
the
sphericalHarmonics
branch
from
d0a9ed9 to
ab8acdc
Compare
|
The examples of this pullrequest are now built and visible in threejsworker. To view them, go to the following link: |
|
I just stumbled on this repository which may also be useful for reference. |
|
@mattdesl very nice. I wonder what Google is using it for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made this PR at @WestLangley's request.
This is an initial implementation of SphericalHarmonics, both the JS class and a shader. I haven't tested it, but I think that this implementation form is pretty close to what we want as it is based on the general standards.
Thus this PR is for others to build upon.