Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to simplify the phong shaders and lights. #7324
attempt to simplify the phong shaders and lights. #7324
Changes from 18 commits
ea9cfe0
d744760
ad75704
74d3aa3
e889e6b
c1df173
7985c8b
8c5bc52
223c383
3f4a946
339e4d3
bbace72
28754cf
e21dd08
d443359
faa1967
56b6472
d8552f3
f25fd9b
c66fd07
fb54728
8d0d454
b101729
ea903ed
ea9f26a
27dc0ad
9bc5094
36c5996
5d4ad85
fa51e8c
f96f6e4
3f48049
bbc81cd
3c9e00f
fdaad8d
0287cab
c45b7cf
8c8f538
c290352
e40d3f7
a101882
95534e3
08fe989
05118ea
ba207f0
b1df023
c5e001a
28997aa
8610ef3
7829fff
23ebff6
26b54cd
f89f27d
89b3dac
ce22ecc
f75c055
d59e16a
e12f233
2d3f699
181973a
0cf45b8
5c6fc49
5ad4d10
d1499b2
752fc8b
082a19d
6737d10
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.