Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around Chrome on Andriod bug - can not use struct constructors. #7556

Merged
merged 2 commits into from
Nov 8, 2015

Conversation

bhouston
Copy link
Contributor

@bhouston bhouston commented Nov 8, 2015

Seems Chrome on Andriod has a bug, you can not use struct initializers. (/ping @kenrussell) They work on Firefox, Chrome in windows, Safari on iOS, and everywhere else it appears, but not on Chrome on Andriod.

This patch fixes the main issue that @mrdoob identified here:

#7324 (comment)

Another issue is that the text in the example on my Andriod id black colored, when it is white on my desktop - but it appears to be a separate issue:

http://threejsworker.com/api/pullrequests/7556/examples/webgl_materials_variations_standard.html

@mrdoob
Copy link
Owner

mrdoob commented Nov 8, 2015

Oh man, that must have been hard to find...

mrdoob added a commit that referenced this pull request Nov 8, 2015
work around Chrome on Andriod bug - can not use struct constructors.
@mrdoob mrdoob merged commit fd310c2 into mrdoob:dev Nov 8, 2015
@mrdoob
Copy link
Owner

mrdoob commented Nov 8, 2015

Thanks!

@MasterJames
Copy link
Contributor

I'm guessing chrome devs would like to know about it and it would not be a patch on threeJS side (eventually? So maybe we should submit and monitor that chrome bug they might have noticed already.). Then again maybe there is no benifit to the other pre-fix way.
Thanks for the dedicated work here everybody.

@kenrussell
Copy link

@bhouston we would very much like to add a test for this to the WebGL conformance suite. Would you be able to please put together a small test case in this directory: https://github.com/KhronosGroup/WebGL/tree/master/sdk/tests/conformance/glsl/bugs and submit a pull request? If you are too busy then at least please file an issue at https://github.com/KhronosGroup/WebGL/issues and tell us exactly what device (or devices) and OS this is happening on, and what the failure mode is, so we can create our own reduced test. Thanks.

@mrdoob
Copy link
Owner

mrdoob commented Nov 11, 2015

Another issue is that the text in the example on my Andriod id black colored, when it is white on my desktop - but it appears to be a separate issue

Turns out is the same issue 😁

@bhouston
Copy link
Contributor Author

@mrdoob, nice! What type of Andriod phone are you testing on BTW so I can share with @kenrussell .

@mrdoob
Copy link
Owner

mrdoob commented Nov 11, 2015

Nexus 5.

@kenrussell
Copy link

Thanks @bhouston for the initial report and @mrdoob for the reduced test case in https://www.shadertoy.com/view/lddGzr . A conformance test for this has been added in KhronosGroup/WebGL#1316 , so once Qualcomm fixes the bug (it affects both the Nexus 4 and 5) it will never regress again. In the future, it would be really helpful if you could submit reduced test cases like these for issues you find. Reducing the test cases does take some time, but it's the only way that bugs like these are fixed and regressions are prevented. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants