Add iOS workaround to BoxGeometry

[paulmasson]

Partial fix #9195

[mrdoob]

Hmm, there needs to be a better solution that this hack I did in the iOS8 days...
Does this still happen in iOS10?

/cc @spite

[mrdoob]

Found a nicer workaround! c0537d2

[paulmasson]

Cool! Only problem is yours is hard-coded for the examples page. How about my updated version for the documentation pages? More flexible.

[mrdoob]

I like it! How about a little bit more compact?

scene.style.width = getComputedStyle( scene ).width;
scene.style.height = getComputedStyle( scene ).height;
scene.setAttribute( 'scrolling', 'no' );

[paulmasson]

Done. Shall I begin adding this fix to the other geometries?

[mrdoob]

Would the code still work if it was in this form?

<iframe id="scene" src="scenes/geometry-browser.html#BoxGeometry"></iframe>

<script>
window.onload = function() {
    var scene = document.getElementById( 'scene' );
    // iOS iframe auto-resize workaround
    if ( /(iPad|iPhone|iPod)/g.test( navigator.userAgent ) ) {
        scene.style.width = getComputedStyle( scene ).width;
        scene.style.height = getComputedStyle( scene ).height;
        scene.setAttribute( 'scrolling', 'no' );
    }
}
</script>

That way the patch/workaround code is independent/separate from the iframe src.

[paulmasson]

Since I was using window.onload, setting the src attribute in the iframe was very inconsistent. Setting the source in the script was also inconsistent as I described in #9195.

I was previously under the impression that onload does not fire for Safari iframes, but it turns out it does. I've updated the workaround again to move the source to the iframe and add an onload function.

Better?

[mrdoob]

Almost!

I don't think you need to wait for the onload. The style applied to the iframe doesn't depend on the iframe being loaded.

I think you should be able to have the code execute directly. Seems to work fine for the examples page.

[paulmasson]

And of course you're right. Another misconception on my part.

[mrdoob]

Sweet!

[mrdoob]

Thanks!

[mrdoob]

And yes, adding it to the other pages would be great!