Set explicit clear color in documentation scenes for iOS #9297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's actually transparent, and its been fixed on iOS 10. But we should indeed add for old versions. |
|
Thanks! |
|
@paulmasson This is misleading, IMO. You are not changing the clear color to black, in this PR; you are setting the clear alpha to 1. I would change this to if that is what you intend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default clear color for iOS is inexplicably white, not black. This is a particular problem for MeshDepthMaterial documentation, since the object is white. Setting the clear color explicitly solves the problem for iOS.