This repository has been archived by the owner on Sep 10, 2020. It is now read-only.
fix: Upgrade to cobalt#346 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobalt's liquid has been changed to fail on missing variables. This could be made less strict in the future. This means that every page reusing a layout needs the variables defined, even if it is to `Nil`. So added - comments - humandate - social_img - subtitle - translations - css
The version of liquid used has a logic bug with testing nil variables, so making the check explicit so it builds correctly. cobalt.rs#346 includes the fix for this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS YET The PR is not yet merged or released. I'm posting PRs for all known cobalt blogs. After that, I'll try to give a feedback window before merging the PR and creating a release.
Feedback on cobalt-org/cobalt.rs#346 is welcome. In addition to this PR, you can peruse the updated documentation.
Commands run
cobalt migrate{% assign social_img = page.data.social_img %}Note: this includes mre/endler.dev#2