Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Add linter to Github actions #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add linter to Github actions #45

wants to merge 7 commits into from

Conversation

mre
Copy link
Owner

@mre mre commented Mar 13, 2020

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mre mre mentioned this pull request Mar 13, 2020
10 tasks
@cmangla
Copy link
Collaborator

cmangla commented Mar 16, 2020

@mre Wow this is turning out to be a lot of work, but looks great!

@mre
Copy link
Owner Author

mre commented Mar 16, 2020

@cmangla, yeah let's take it as an opportunity to clean up non-idiomatic code.
I think the result is great: 6e48d48
If we all fix a few of those lints from time to time, we'll be in a much better position soon.

@mre
Copy link
Owner Author

mre commented Mar 16, 2020

Of course, after pylint, we still have mypy to tackle. And who knows what else. 😆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants