Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate Language Movie names in Table View. #1341

Closed
Dubwize opened this issue Aug 25, 2020 · 11 comments
Closed

Alternate Language Movie names in Table View. #1341

Dubwize opened this issue Aug 25, 2020 · 11 comments
Labels
bug Something isn't working release/0.2 Issues that should be included in the 0.2 release

Comments

@Dubwize
Copy link

Dubwize commented Aug 25, 2020

Bug report

Describe the bug
Movie names are not pulling English titles when they are Japanese.

To Reproduce
After the movies are imported;
Go to Movies -> Tables

Expected behavior
Name should be populated the same as they are in Emby, even if there are various names available.

Screenshots
Here are two movies listed in the tables display of EmbyStat.
image

Here is the same movies from Emby
image
image

Battle Royal's info on TheMovieDB
image

System (please complete the following information):

  • OS: Debian
  • Browser: Brave
  • Version beta.25
  • Media server type: Emby

Additional context
I would think that the metadata scrape should either populate whats already available from Emby, or if it's doing a new scrape from TVDB or TheMovieDB, then it should include your language selection when determining how/what to display as the title.

Couple more as reference:
image
image

@Dubwize
Copy link
Author

Dubwize commented Aug 25, 2020

As a side note. Nice work on beta.25. Very nice indeed.

@mregni
Copy link
Owner

mregni commented Aug 30, 2020

Hi @Dubwize, thanks for the bug log. I was on holiday so I just now saw your issue.

It is strange indeed that the Japanese titles are shown because I'm mapping the Emby data directly into EmbyStat. I did see that I'm using the OriginalTitle property, maybe Name or even SortName would be better indeed.

@Dubwize
Copy link
Author

Dubwize commented Aug 31, 2020

No worries man. Gotta get out and unplug sometimes.

I included that "Original Name" image because I assumed that was the value you were pulling. Also, and i'm not Emby variable guru, but i thought SortName was a user populated field, used to force Emby to override the title with what you have entered.

Thanks, and again, keep up the great work, this new version is amazing.

@Dubwize
Copy link
Author

Dubwize commented Aug 31, 2020

Thought I would drop this here. Looks like I was right about SortName. It's user defined. I would suggest using SortName first, and if that field = null, then use Title.

image

@Happy2Play
Copy link

Happy2Play commented Aug 31, 2020

Thought I would drop this here. Looks like I was right about SortName. It's user defined. I would suggest using SortName first, and if that field = null, then use Title.

image

Technically that field is blank in the UI but not the database. At least in Emby

DB

@mregni
Copy link
Owner

mregni commented Aug 31, 2020

Yeah, I'm also always receiving a sort name when I fetch the data from Emby. Displaying the SortName is a bad idea because this can happen
image

So will try to display the Name but sorting the name column needs to be done on SortName. Sounds like a plan?

@mregni mregni added bug Something isn't working release/0.2 Issues that should be included in the 0.2 release labels Aug 31, 2020
@Dubwize
Copy link
Author

Dubwize commented Aug 31, 2020

Yeah, I'm also always receiving a sort name when I fetch the data from Emby. Displaying the SortName is a bad idea because this can happen
image

So will try to display the Name but sorting the name column needs to be done on SortName. Sounds like a plan?

Sounds good to me.
.... and now that I know emby is storing everything in a sqlite db, I'll be able to dig up more info for you, in advance, next time.

mregni added a commit that referenced this issue Aug 31, 2020
Using Name to display in movie table #1341
@mregni
Copy link
Owner

mregni commented Aug 31, 2020

@Dubwize, can you check the new nightly build (0.2.1-dev.1365) to see if your problem is fixed? Nightlies are only available in Docker containers. Let me know if you need a Windows artifact.

@Dubwize
Copy link
Author

Dubwize commented Sep 1, 2020

I use a linux 'package' I can spin up a docker though and give it a test in a bit.

@Dubwize
Copy link
Author

Dubwize commented Sep 1, 2020

Small spelling mistake in that nightly. might be in the main build also. "Synchronization"

image

Unfortunately I can not get the docker nightly to do a media sync. The issue is, it doesn't do name resolution correctly, so can't get out to TheTVdb. To note, I run my dockers on a macvlan network.

docker create
--name=Embystat
--net="docker_vlan20"
--ip="10.10.20.145"
--dns="10.10.20.1"
-p 6555:6555
-v /volume1/docker/embystat:/app/config
uping/embystat:nightly

... all other dockers have access outside the network without issues

Using apt update as an example. You can see it fails DNS lookups from within the EmbyStat Docker
image

This is probably an issue with embystat:latest also, but i haven't tried to deploy it.

@mregni
Copy link
Owner

mregni commented Sep 7, 2020

@Dubwize, I'm not really familiar with how the DNS resolving should work inside docker and how I need to change my code to use the docker DNS settings. You don't need to try the 'embystat:latest' since it's not updated anyway.

Can you give me a docker image example that does work on your system? I could have a look at their docker image file to see if I'm missing something.

edit: fixing the type as well, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release/0.2 Issues that should be included in the 0.2 release
Projects
None yet
Development

No branches or pull requests

3 participants