Produce a real false value instead of "false". Quick n dirty hack to make it work #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue: #14 |
jamen
requested changes
Jan 31, 2018
create.js
Outdated
|
|
||
| // Directive attributes | ||
| if (name.indexOf(directive) === 0) { | ||
| if (name[0] === directive) { |
There was a problem hiding this comment.
A directive could be more than one char which is why I went the indexOf route. Other method could be to just hardcode the char instead of option.
There was a problem hiding this comment.
Oh yeah my bad, I missed that. this change didn't belong on this branch anyway
mreinstein
reviewed
Oct 28, 2023
| @@ -31,6 +31,9 @@ function create (modules, options) { | |||
| var data = {} | |||
| for (var i = 0, max = names.length; max > i; i++) { | |||
| var name = names[i] | |||
| if (input[name] === 'false') { | |||
There was a problem hiding this comment.
I believe this has broken the case where we want explicit "false" values for attributes. e.g.,
html`<img src="..." draggable="false" />`we end up throwing out the false attribute. This is what gets rendered:
<img src="..." />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.