Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Reflect.defineProperty property name mismatch #57

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fixes Reflect.defineProperty property name mismatch #57

merged 1 commit into from
Jul 10, 2024

Conversation

mhassan1
Copy link
Collaborator

This PR fixes the Reflect.defineProperty polyfill, which uses the result of the ToPropertyDescriptor abstract operation incorrectly.

@mhassan1 mhassan1 marked this pull request as ready for review July 10, 2024 21:44
romainmenke
romainmenke approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Curious how you caught this :)

@mhassan1 mhassan1 merged commit 3b924bc into main Jul 10, 2024
17 checks passed
@mhassan1 mhassan1 deleted the fix-reflect-defineproperty branch July 10, 2024 22:05
@mhassan1
Copy link
Collaborator Author

Curious how you caught this :)

I noticed it while working on the URL polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainmenke romainmenke romainmenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhassan1 @romainmenke